Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move tank harness to outer clothing #2028

Merged
merged 10 commits into from
Sep 20, 2024
Merged

Move tank harness to outer clothing #2028

merged 10 commits into from
Sep 20, 2024

Conversation

whatston3
Copy link
Contributor

About the PR

Moves tank harness to outer clothing rather than being hidden in their own category.

Why / Balance

#2022.

How to test

  1. Create a new vox character.
  2. Swap between jobs in character setup.
  3. Your outfit should include your weird tank harness.

Media

Default pirate captain outfit. Fearsome.
image

Default valet outfit. Nice arm holes.
image

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

  • fix: The tank harness for Vox is now in the outer clothing option. Double check your loadouts.

@whatston3 whatston3 mentioned this pull request Sep 17, 2024
Open
@github-actions github-actions bot added the Merge Conflict This PR has conflicts that prevent merging label Sep 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict This PR has conflicts that prevent merging label Sep 18, 2024
@dvir001 dvir001 requested review from dvir001 and ErhardSteinhauer and removed request for dvir001 September 19, 2024 12:43
@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Sep 19, 2024
@ErhardSteinhauer
Copy link
Contributor

Tried spawning with different outer clothing articles (including ones compatible with voxes), the harness still spawns instead of selected item.

@whatston3
Copy link
Contributor Author

whatston3 commented Sep 19, 2024 •
edited
Loading

Tried spawning with different outer clothing articles (including ones compatible with voxes), the harness still spawns instead of selected item.

Any particular role/loadout? Retested as contractor bringing a voidmedic suit, no issue, same with the valet and the valet vest.

What you're describing is the old behaviour on master - are you sure your branch under test is correct and up-to-date?

@ErhardSteinhauer
Copy link
Contributor

Tried merc with lab coat, the branch is correct, but might not be the latest (grabbed it yesterday, when we were in VC)

@whatston3
Copy link
Contributor Author

Tried merc with lab coat, the branch is correct, but might not be the latest (grabbed it yesterday, when we were in VC)

Should be resolved. I missed one GroupTankHarness reference. Sorry about that.

@dvir001 dvir001 merged commit 1238a88 into new-frontiers-14:master Sep 20, 2024
11 checks passed
FrontierATC added a commit that referenced this pull request Sep 20, 2024
@FrontierATC
Automatic Changelog (#2028)
56dfc7a
@whatston3 whatston3 deleted the 2024-09-17-vox-loadouts branch September 21, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvir001 dvir001 dvir001 approved these changes

@ErhardSteinhauer ErhardSteinhauer Awaiting requested review from ErhardSteinhauer

Assignees
No one assigned
Labels
No C# Status: Needs Review This PR is awaiting reviews YML
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@whatston3 @ErhardSteinhauer @dvir001